Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement](doris-future) Support "REGR_" aggregation functions (PART II) #41240

Merged
merged 19 commits into from
Oct 8, 2024
Merged

[Enhancement](doris-future) Support "REGR_" aggregation functions (PART II) #41240

merged 19 commits into from
Oct 8, 2024

Conversation

Yoruet
Copy link
Contributor

@Yoruet Yoruet commented Sep 24, 2024 •
edited
Loading

Proposed changes

Issue Number: close #38975

mysql> select * from test;
+------+------+------+
| id   | x    | y    |
+------+------+------+
|    1 |   18 |   13 |
|    3 |   12 |    2 |
|    5 |   10 |   20 |
|    2 |   14 |   27 |
|    4 |    5 |    6 |
+------+------+------+
5 rows in set (0.07 sec)

mysql> select regr_slope(y,x) , regr_intercept(y,x) from test;
+--------------------+----------------------+
| regr_slope(y, x)   | regr_intercept(y, x) |
+--------------------+----------------------+
| 0.6853448275862069 |    5.512931034482759 |
+--------------------+----------------------+
1 row in set (0.15 sec)

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Yoruet Yoruet changed the title add regr_intercept and regr_slope aggregate functions [Enhancement](doris-future) Support "REGR_" aggregation functions (PART II) Sep 24, 2024
@zhiqiang-hhhh
Copy link
Contributor

@Yoruet Null property of regr_slope and regr_intercept should be AlwaysNullable on FE, so need to do some modification on be.

@zhiqiang-hhhh
Copy link
Contributor

@Yoruet You can take this pr #40945 as a reference.

@zhiqiang-hhhh
Copy link
Contributor

@Yoruet I add more comments with detail information.

zhiqiang-hhhh
zhiqiang-hhhh reviewed Sep 27, 2024
View reviewed changes
be/src/vec/aggregate_functions/aggregate_function_regr_intercept.cpp Outdated Show resolved Hide resolved
...re/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/RegrIntercept.java Outdated Show resolved Hide resolved
be/src/vec/aggregate_functions/aggregate_function_regr_intercept.h Outdated Show resolved Hide resolved
be/src/vec/aggregate_functions/aggregate_function_regr_intercept.h Outdated Show resolved Hide resolved
be/src/vec/aggregate_functions/aggregate_function_regr_intercept.h Outdated Show resolved Hide resolved
be/src/vec/aggregate_functions/aggregate_function_regr_intercept.h Outdated Show resolved Hide resolved
be/src/vec/aggregate_functions/aggregate_function_regr_intercept.h Outdated Show resolved Hide resolved
be/src/vec/aggregate_functions/aggregate_function_regr_intercept.h Outdated Show resolved Hide resolved
@zhiqiang-hhhh
Copy link
Contributor

zhiqiang-hhhh commented Sep 27, 2024 •
edited
Loading

Yoruet#1

@Yoruet I did some fix on regr_intercept on your branch, you can merge the pull request and do modification on other function. Test case should be taked.

Reference https://dbfiddle.uk/MmKrIU9r

zhiqiang-hhhh
zhiqiang-hhhh suggested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Null value is not processed correctly.

@Yoruet
Copy link
Contributor Author

Yoruet commented Sep 27, 2024

Null value is not processed correctly.

Can you provide corresponding test samples to me

@zhiqiang-hhhh
Copy link
Contributor

Null value is not processed correctly.

Can you provide corresponding test samples to me

@Yoruet You can try test case added in this pr Yoruet#1 on regr_slope

@Yoruet
Copy link
Contributor Author

Yoruet commented Sep 27, 2024 •
edited
Loading

Null value is not processed correctly.

Can you provide corresponding test samples to me

@Yoruet You can try test case added in this pr Yoruet#1 on regr_slope

Null value is not processed correctly.

Can you provide corresponding test samples to me

@Yoruet You can try test case added in this pr Yoruet#1 on regr_slope

@zhiqiang-hhhh I compared the data in the test_regr_intercept.out file with that in https://dbfiddle.uk/MmKrIU9r, and it seems that there is nothing wrong. Can you provide more detailed information?

@zhiqiang-hhhh
Copy link
Contributor

Null value is not processed correctly.

Can you provide corresponding test samples to me

@Yoruet You can try test case added in this pr Yoruet#1 on regr_slope

Null value is not processed correctly.

Can you provide corresponding test samples to me

@Yoruet You can try test case added in this pr Yoruet#1 on regr_slope

@zhiqiang-hhhh I compared the data in the test_regr_intercept.out file with that in https://dbfiddle.uk/MmKrIU9r, and it seems that there is nothing wrong. Can you provide more detailed information?

The reason test_regr_intercept is correct is that I re-write the implementation of regr_itercept in that PR (I created that pull request on your branch to give you an example on how to fix regr_itercept).

You can compare the code I submitted with your implementation of regr_itercept, and do fix on regr_slope in a same way.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zhiqiang-hhhh
Copy link
Contributor

We need todo a refactor on all REGR_ like agg functions, to make code simple. These agg functions have same structure.
eg. #39187

@Yoruet
Copy link
Contributor Author

Yoruet commented Sep 29, 2024 •
edited
Loading

We need todo a refactor on all REGR_ like agg functions, to make code simple. These agg functions have same structure. eg. #39187

Does it include only regr_slope and regr_intercept or does it include other regr_ functions such as regr_sxx

@zhiqiang-hhhh
Copy link
Contributor

We need todo a refactor on all REGR_ like agg functions, to make code simple. These agg functions have same structure. eg. #39187

Does it include only regr_slope and regr_intercept or does it include other regr_ functions such as regr_sxx

This is just a comment to remind us to do a refactor in the future, does not means we need to do refactor in this pr.

@HappenLee
Copy link
Contributor

@Yoruet please add doc in https://github.com/apache/doris-website thank you very mush

@Yoruet Yoruet mentioned this pull request Sep 29, 2024
Open
6 tasks
@Yoruet
Copy link
Contributor Author

Yoruet commented Sep 29, 2024

@Yoruet please add doc in https://github.com/apache/doris-website thank you very mush

I have already pr the doc.plz check it

@Yoruet Yoruet requested a review from HappenLee October 2, 2024 11:34
HappenLee
HappenLee approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

PR approved by at least one committer and no changes requested.

@HappenLee
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.30% (9632/25825)
Line Coverage: 28.68% (79854/278453)
Region Coverage: 28.11% (41291/146877)
Branch Coverage: 24.74% (21039/85034)
Coverage Report: http://coverage.selectdb-in.cc/coverage/68d8d740c68642db67051a62d6b3b8c18319ac4e_68d8d740c68642db67051a62d6b3b8c18319ac4e/report/index.html

@zhangstar333 zhangstar333 merged commit 0e5fd2f into apache:master Oct 8, 2024
22 of 26 checks passed
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Oct 10, 2024
@Yoruet @zhiqiang-hhhh @eldenmoon
[Enhancement](doris-future) Support "REGR_" aggregation functions (PA…
3eb4696 
…RT II) (apache#41240)

## Proposed changes

Issue Number: close apache#38975

<!--Describe your changes.-->
```sql
mysql> select * from test;
+------+------+------+
| id   | x    | y    |
+------+------+------+
|    1 |   18 |   13 |
|    3 |   12 |    2 |
|    5 |   10 |   20 |
|    2 |   14 |   27 |
|    4 |    5 |    6 |
+------+------+------+
5 rows in set (0.07 sec)

mysql> select regr_slope(y,x) , regr_intercept(y,x) from test;
+--------------------+----------------------+
| regr_slope(y, x)   | regr_intercept(y, x) |
+--------------------+----------------------+
| 0.6853448275862069 |    5.512931034482759 |
+--------------------+----------------------+
1 row in set (0.15 sec)

```

---------

Co-authored-by: zhiqiang-hhhh <seuhezhiqiang@163.com>
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@Yoruet @zhiqiang-hhhh @cjj2010
[Enhancement](doris-future) Support "REGR_" aggregation functions (PA…
6aad4f2 
…RT II) (apache#41240)

## Proposed changes

Issue Number: close apache#38975

<!--Describe your changes.-->
```sql
mysql> select * from test;
+------+------+------+
| id   | x    | y    |
+------+------+------+
|    1 |   18 |   13 |
|    3 |   12 |    2 |
|    5 |   10 |   20 |
|    2 |   14 |   27 |
|    4 |    5 |    6 |
+------+------+------+
5 rows in set (0.07 sec)

mysql> select regr_slope(y,x) , regr_intercept(y,x) from test;
+--------------------+----------------------+
| regr_slope(y, x)   | regr_intercept(y, x) |
+--------------------+----------------------+
| 0.6853448275862069 |    5.512931034482759 |
+--------------------+----------------------+
1 row in set (0.15 sec)

```

---------

Co-authored-by: zhiqiang-hhhh <seuhezhiqiang@163.com>
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
@Yoruet @zhiqiang-hhhh @amorynan
[Enhancement](doris-future) Support "REGR_" aggregation functions (PA…
b2ea76e 
…RT II) (apache#41240)

## Proposed changes

Issue Number: close apache#38975

<!--Describe your changes.-->
```sql
mysql> select * from test;
+------+------+------+
| id   | x    | y    |
+------+------+------+
|    1 |   18 |   13 |
|    3 |   12 |    2 |
|    5 |   10 |   20 |
|    2 |   14 |   27 |
|    4 |    5 |    6 |
+------+------+------+
5 rows in set (0.07 sec)

mysql> select regr_slope(y,x) , regr_intercept(y,x) from test;
+--------------------+----------------------+
| regr_slope(y, x)   | regr_intercept(y, x) |
+--------------------+----------------------+
| 0.6853448275862069 |    5.512931034482759 |
+--------------------+----------------------+
1 row in set (0.15 sec)

```

---------

Co-authored-by: zhiqiang-hhhh <seuhezhiqiang@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiang-hhhh zhiqiang-hhhh zhiqiang-hhhh approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement](doris-future) Support "REGR_" aggregation functions (PART II)
5 participants
@Yoruet @doris-robot @zhiqiang-hhhh @HappenLee @zhangstar333